SaveManager cleanup#3386
Merged
briaguya0 merged 2 commits intoHarbourMasters:develop-macreadyfrom Nov 14, 2023
Merged
Conversation
…veManager::Init` to SM's constructor. Comment on `Init` to mention it's not an initializer for `SaveManager`. Added check for `SaveManager::SaveSection` to prevent firing a save worker if the game is already exited from a reset.
briaguya0
approved these changes
Nov 12, 2023
Contributor
briaguya0
left a comment
There was a problem hiding this comment.
left a non-blocking nitpick comment
…t the start of `SaveManager::Init()`.
briaguya0
requested changes
Nov 12, 2023
Contributor
briaguya0
left a comment
There was a problem hiding this comment.
i misunderstood what was happening with my prior approval, and the code has changed since then, this is just to make my green check go away (i'll re-review later)
briaguya0
approved these changes
Nov 14, 2023
Archez
approved these changes
Nov 14, 2023
Contributor
Archez
left a comment
There was a problem hiding this comment.
Changes look reasonable to me (class initializers performed in the constructor).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move thread pool initialization and
OnExitGameregistration fromSaveManager::Init()to SM's constructor.This is necessary because
SaveManager::Init()is merely an extension ofSram_InitSram(), and as such is not an initializer forSaveManageritself. Before now, every reset would add another registration forOnExitGameand reinitialize the thread pool, which was definitely not a good thing.Also added call to
ThreadPoolWait()inInit(), as it was relatively easy, especially on Anchor, to trigger a save afterOnExitGamewas already processed, thus introducing the possibility thatInit()would be loading a file (or reinitializing the thread pool, for that matter) at the same time the save worker was writing to the file, causing it to try to load incomplete and malformed save data.Build Artifacts