[Feature/fix] Save to temp file first#3376
Merged
briaguya0 merged 2 commits intoHarbourMasters:develop-macreadyfrom Nov 15, 2023
Merged
[Feature/fix] Save to temp file first#3376briaguya0 merged 2 commits intoHarbourMasters:develop-macreadyfrom
briaguya0 merged 2 commits intoHarbourMasters:develop-macreadyfrom
Conversation
Merged
ea33212 to
e969735
Compare
Add "Save finish" info log message.
e969735 to
98eb46c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to the nature of crashes sometimes causing save corruption, and then causing more severe crashes because of the corruption, this PR changes
SaveManager::SaveFileThreadedto utilize a temp file to save to, which is then copied to the real save file, to try to preserve all save files in a workable state, even if a crash interrupts the save thread. Also adds a "Save finish" log message to the end of the function to mirror the log message at the start of it.Build Artifacts