[Bugfix] Fixes check tracker crash on max debug file creation#3309
Merged
aMannus merged 2 commits intoHarbourMasters:developfrom Nov 4, 2023
Merged
[Bugfix] Fixes check tracker crash on max debug file creation#3309aMannus merged 2 commits intoHarbourMasters:developfrom
aMannus merged 2 commits intoHarbourMasters:developfrom
Conversation
…x crash during max debug file creation.
Contributor
Author
|
This has made me realize that RCAreas need to be in their own table, as I have |
Contributor
Author
|
This would also simplify the item locations tables a small bit, too. It'll be done on v3, though. |
inspectredc
approved these changes
Oct 20, 2023
Archez
approved these changes
Oct 29, 2023
garrettjoecox
approved these changes
Oct 30, 2023
briaguya0
approved these changes
Nov 4, 2023
aMannus
approved these changes
Nov 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't even know why I was relying on a range of
SceneIDs anyway, I already had access to the scene IDs I wanted to check inRCAreaFromSceneID. This changes the initialization to iterate overRCAreaFromSceneIDand use the values directly, fixing said crash (was trying to look up a dungeon map for a scene that didn't have an associated area inRCAreaFromSceneID).Also renamed the map to
DungeonRCAreasBySceneIDfor clarification.Build Artifacts