Fix greg as reward logic#3297
Merged
garrettjoecox merged 1 commit intoHarbourMasters:developfrom Oct 19, 2023
Merged
Conversation
garrettjoecox
approved these changes
Oct 16, 2023
Archez
approved these changes
Oct 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initially the reward logic would internally be set to 'greg as reward' for both the bridge and lacs rewards only if at least 1 had that option selected. This lead to scenarios where the bridge rewards would be set to standard, and the lacs rewards would be set to greg as reward, which caused the bridge logic to require greg
Build Artifacts