Remove disabled special hints and warp song hints from the spoiler log#3110
Merged
garrettjoecox merged 15 commits intoHarbourMasters:develop-randofrom Oct 22, 2023
Merged
Conversation
Contributor
Author
|
Do not merge, known issue with loading files in. |
d4cd4aa to
55990c0
Compare
Contributor
Author
|
OK this is ready to merge now. While testing I found another warp song hints bug where if you have a randomiser seed leaded into the main menu, but a save with a different seed, and both have warp song hints enabled, then there will be extra characters in the warp song hints of the save game where the loaded seed has longer destination names than the saved seed. I confirmed this bug is in the 7.1.1 release however, so is not related to my changes and so should be fixed separately. |
b9aae12 to
7d625e2
Compare
dec1039 to
2d6d12a
Compare
garrettjoecox
approved these changes
Oct 15, 2023
2d6d12a to
250670b
Compare
…song shuffle text from spoiler logs
…song shuffle text from spoiler logs
…eing hinted elsewhere unless they are locked by that item.
…ial final frogs hint is enabled.
250670b to
5dad0de
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A small change to remove special hints that are disabled from the spoiler log. Currently they have blank strings for entries. Needs testing due to potential issues with the spoiler log seed loader.
Due to git issues, this now includes #3060 , check that description for full feature list
Build Artifacts