Fix: Carpet Merchant rando GiveItem distance check#3102
Merged
leggettc18 merged 1 commit intoHarbourMasters:develop-sulufrom Aug 6, 2023
Merged
Fix: Carpet Merchant rando GiveItem distance check#3102leggettc18 merged 1 commit intoHarbourMasters:develop-sulufrom
leggettc18 merged 1 commit intoHarbourMasters:develop-sulufrom
Conversation
stratomaster64
approved these changes
Aug 3, 2023
leggettc18
approved these changes
Aug 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The carpet merchant had an incorrect actor dist check for the rando give item call, causing the vanilla bombchus to be granted instead if the player was on the far edge of the "speak" radius.
This PR just matches the rando dist checks with the vanilla ones.
I've also audited the rest of the code base and confirmed there are no other mismatching distance checks for vanilla/rando give item situations.
Build Artifacts