Rando: Infinite Upgrades#3099
Conversation
|
Note that there's still a visual bug that causes the infinite bombchu textbox to be replaced with the normal bombchu textbox if gotten from progressive bombchus. |
|
I'm a big fan of this concept! I'm all for options that add more things to the item pool. |
|
|
||
| { RAND_INF_KAK_100_GOLD_SKULLTULA_REWARD, "KAK_100_GOLD_SKULLTULA_REWARD" }, | ||
| { RAND_INF_GREG_FOUND, "RAND_INF_GREG_FOUND" }, | ||
|
|
There was a problem hiding this comment.
Obligatory merge conflict warning :)
| if (AMMO(ITEM_BOMBCHU) > 50) { | ||
| AMMO(ITEM_BOMBCHU) = 50; | ||
| } | ||
| } |
There was a problem hiding this comment.
I don't think this section should have been removed either. If your infinite upgrades are turned off, and you undo the change above to the number of progressive bombchu packs in the pool, then we still need this code to handle getting multiple progressive bombchu packs.
There was a problem hiding this comment.
This is fine because of the code added in randomizer.cpp:
case RG_PROGRESSIVE_BOMBCHUS:
if (INV_CONTENT(ITEM_BOMBCHU) == ITEM_NONE) {
return (GetItemID)RG_PROGRESSIVE_BOMBCHUS;
} else if (infiniteUpgrades) {
return (GetItemID)RG_BOMBCHU_INF;
} else if (AMMO(ITEM_BOMBCHU) < 5) {
return GI_BOMBCHUS_10;
} else {
return GI_BOMBCHUS_5;
}Now the progressive bombchus rg is only used when you originally get them, I made this change because it gave me problems the way it was implemented before and I figured it was fine as progressive bombchus are the only item that does logic in Randomizer_Item_Give. I can change it back if it's preferred that way.
There was a problem hiding this comment.
Also as a side effect of this, progressive bombchus only sparkle if you don't have them yet, instead of always.
|
Alright, had a deep look. Just wanted to mention the obligatory |
Did the |
|
Yeah, I don't think anything is setup for that yet. Was just lamenting that fact. |
|
@Pepe20129 do you intend on porting this to rando v3? |
|
Yes, after my other rando v3 prs get merged. |
|
closing in favor of the rando v3 version #3942 |
This PR adds an option for rando which adds infinite upgrades for every consumable item (except magic beans):
The counts dissapear when you have the infinite upgrades:
Magic turns blue (can be changed in cosmetic editor) when you have its infinite upgrade:
Build Artifacts