Skip to content

[Accessibility] Tweak Pause menu TTS functions#3098

Merged
leggettc18 merged 2 commits intoHarbourMasters:develop-sulufrom
Archez:tts-kaleido-tweaks
Aug 13, 2023
Merged

[Accessibility] Tweak Pause menu TTS functions#3098
leggettc18 merged 2 commits intoHarbourMasters:develop-sulufrom
Archez:tts-kaleido-tweaks

Conversation

@Archez
Copy link
Contributor

@Archez Archez commented Jul 28, 2023 •
edited
Loading

This PR aims to fix and tweak TTS features for the pause menu.

The following bugs are fixed:

  • Pieces of heart was incorrectly being read out as "Heart Containers"
  • Pieces of heart was reading out the wrong number of collected hearts
  • Magic beans was always reading out 0 for the quantity
  • Biggoron sword was incorrectly being read out as "PIECE OF HEART 2"
  • The equipment screen would read out swords/shield/boots/tunics even if you didn't have them collected (blank spaces)
  • Moving over an empty slot on the quest status screen and then moving back to the previous slot would not re-read it back out

The following tweaks were made:

  • Current hearts are now read out as the amount of hearts and fraction you have, mimicking the lifemeter in the HUD (e.g. 14.25 hearts)
  • Current magic is now read out as a percentage
  • All TTS that reads out a number now has a slight pause between the item name and the number

The following features are added:

  • The pause menu page is read out when the pages are rotated and when the pause menu is opened
  • The map menu will additionally read out if you are in the overworld or the name of the dungeon
  • The map menu now reads out the floor/basement numbers
  • The equipment menu will now indicate which sword/shield/tunic/boots are equipped when hovered over
  • Items will read out what button they are assigned to when hovered
  • The save prompt/game saved is now read out for TTS

Fixes #2800

Build Artifacts

@Computerfan23
Copy link

Computerfan23 commented Jul 28, 2023

Thanks for this pr @Archez! This is really helpful and covers up what i described earlier and much more.

@Archez Archez force-pushed the tts-kaleido-tweaks branch from 42334aa to 3f26d1c Compare July 29, 2023 18:32
@Archez Archez force-pushed the tts-kaleido-tweaks branch from 3f26d1c to 5984c51 Compare August 11, 2023 15:37
@Archez Archez changed the base branch from develop to develop-sulu August 11, 2023 15:38
@Archez
Copy link
Contributor Author

Archez commented Aug 11, 2023

Rebased to develop-sulu

briaguya0
briaguya0 approved these changes Aug 11, 2023
View reviewed changes
Copy link
Contributor

@briaguya0 briaguya0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@leggettc18 leggettc18 merged commit 78790fe into HarbourMasters:develop-sulu Aug 13, 2023
@Archez Archez mentioned this pull request Nov 29, 2023
Closed
@Archez Archez deleted the tts-kaleido-tweaks branch February 23, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leggettc18 leggettc18 leggettc18 approved these changes

@briaguya0 briaguya0 briaguya0 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Text to speech issue.

4 participants

@Archez @Computerfan23 @leggettc18 @briaguya0