Add exact item and check to the spoiler log for WotH hints#3043
Add exact item and check to the spoiler log for WotH hints#3043leggettc18 merged 1 commit intoHarbourMasters:develop-sulufrom
Conversation
|
You don't need to provide builds, the CI will build automatically once I approve the workflow to run. You are a first time contributor so we have to approve your changes for CI to run on manually once. Just so I'm clear, before now WOTH hints weren't being added to the spoiler log at all? If so, that sounds like a bug, which means we would want this to go to the develop-sulu branch so it can get into Sulu Bravo. Can you rebase this change onto that branch? |
|
No, they were being added, but only had the WotH type, area, and hint text in the spoiler. This adds exact check and item being referenced to the WotH hint entries in the spoiler specifically. |
|
Ah ok, I still think it probably should have already been in the spoiler log and this change should probably get rebased to develop-sulu, but I'm down to hear other opinions on this one. |
|
I mean, before my hint expansion PR, it was just printing the hint text, and that wasn't targeted as a bugfix, so this is just an expansion of that basically. Only error was oversight, really. |
As title.
Do i need to provide builds for this 2 line change?