Skip to content

Ivan d-pad items + items link to item used rather than slot#2884

Merged
garrettjoecox merged 3 commits intoHarbourMasters:developfrom
inspectredc:ivan-buttons
Nov 6, 2023
Merged

Ivan d-pad items + items link to item used rather than slot#2884
garrettjoecox merged 3 commits intoHarbourMasters:developfrom
inspectredc:ivan-buttons

Conversation

@inspectredc
Copy link
Member

@inspectredc inspectredc commented May 12, 2023

This PR lets ivan use d-pad equips when they are enabled and links the item used by ivan to the item equipped rather than the slot the item was equipped over. This allows items which are equip swapped to be used properly and will allow for use with more items as well as any custom items.

Build Artifacts

@stratomaster64
Copy link
Contributor

I actually had a similar Ivan branch that I was gonna PR and you beat me to it :(
However, I did add functionality for other items so not sure how you wanted to handle it.

@inspectredc
Copy link
Member Author

I actually had a similar Ivan branch that I was gonna PR and you beat me to it :( However, I did add functionality for other items so not sure how you wanted to handle it.

Happy to close this and put this fix in with yours, this was something I'd been meaning to get around to so I could add mods and things more easily but hadnt felt like it til today :p

@inspectredc inspectredc reopened this Sep 14, 2023
Copy link
Contributor

@briaguya0 briaguya0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@garrettjoecox garrettjoecox merged commit 8b78cb8 into HarbourMasters:develop Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants