CrowdControl 2.0: Fix several effects by no longer relying on received parameter to be 0#2870
Merged
leggettc18 merged 1 commit intoHarbourMasters:develop-spockfrom May 10, 2023
Conversation
leggettc18
approved these changes
May 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was relying on the parameter I receive from the CC client to be 0 by having a function assign the received parameter if I didn't set the parameter by myself. The 2.0 SDK indeed returns the parameter as 0 when not specifically set by effect quantities etc, but the live app was returning a parameter of 1.
This PR removes this reliance and builds on the parameter to be 0 when intializing it (this was already happening) instead, and assigning the received parameter manually whenever neccesary (essentially any effect that requires a positive quantity).
Build Artifacts