fix: don't crash when changing margins#2828
Merged
leggettc18 merged 1 commit intoHarbourMasters:develop-spockfrom May 4, 2023
Merged
fix: don't crash when changing margins#2828leggettc18 merged 1 commit intoHarbourMasters:develop-spockfrom
leggettc18 merged 1 commit intoHarbourMasters:develop-spockfrom
Conversation
for some reason we were getting garbage data in cvarNameMargins when doing things the `const char *` way. i wasn't able to figure out why that was getting garbage but this makes it so we don't get garbage in there
leggettc18
approved these changes
May 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for some reason we were getting garbage data in
cvarNameMarginsandcvarPosDatawhen doing things theconst char *way. i wasn't able to figure out why that was getting garbage but this makes it so we don't get garbage in thereBuild Artifacts