Fix: Bottle filling action updating all empty bottles#2817
Merged
leggettc18 merged 1 commit intoHarbourMasters:develop-spockfrom May 4, 2023
Merged
Fix: Bottle filling action updating all empty bottles#2817leggettc18 merged 1 commit intoHarbourMasters:develop-spockfrom
leggettc18 merged 1 commit intoHarbourMasters:develop-spockfrom
Conversation
briaguya0
approved these changes
May 3, 2023
Contributor
|
Just so I'm clear, is the "all bottles filling" situation currently an issue in dev-spock? Or was that dev-only and this is just adding the early return for correctness? |
Contributor
Author
Bug in Spock. |
Contributor
|
We talked about this in Discord, but just so that it's here for posterity, the glitch only happened with non-swinging bottle fillers, such as poes or buying potions from shops. And confirmed this fixes it. |
leggettc18
approved these changes
May 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the GetItem hook rework, the early returns for bottle filling were removed accidentally. A previous bug in dev testing exposed one of these cases and a break was re-added back. The other case was still missing and causing it so when filling a bottle, all empty bottles were replaced, rather than just one bottle only.
This just adds back a break statement to replicate the early return from before the hook rework.
Original code change for reference:
Build Artifacts