Tweak: Reset trade item cycling when pausing or changing pages#2808
Tweak: Reset trade item cycling when pausing or changing pages#2808leggettc18 merged 2 commits intoHarbourMasters:develop-spockfrom
Conversation
inspectredc
left a comment
There was a problem hiding this comment.
Not a big deal but for me it feels safer to have the function be implemented on the save opening update (func_808265BC) in case of any issue the menu has when closing.
That's a good point. Can't think of a situation where that would fail, but easy enough to move anyways. |
inspectredc
left a comment
There was a problem hiding this comment.
LGTM, pause state 3 definitely makes more sense yea
We have flags that track when the player is in a "trade item cycling" mode for adult/child trade items. This mode is unset if you press A again, or equip the item to a C-button. However, if you press B or Start to unpause while mid-cycling, the next time you pause you are still in the cycling state.
I added a method that is called at beginning of the pause init flow that will manually set these flags back to false to address this. I also call this method when the kelido page is switched left or right.
Fixes #2794
Build Artifacts