Fix: MQ dungeons crashing by not using MQ textures#2764
Merged
leggettc18 merged 1 commit intoHarbourMasters:develop-spockfrom Apr 28, 2023
Merged
Fix: MQ dungeons crashing by not using MQ textures#2764leggettc18 merged 1 commit intoHarbourMasters:develop-spockfrom
leggettc18 merged 1 commit intoHarbourMasters:develop-spockfrom
Conversation
briaguya0
approved these changes
Apr 28, 2023
Contributor
|
Looks good to me! Will give it a quick test when Windows build is done. |
leggettc18
approved these changes
Apr 28, 2023
Contributor
leggettc18
left a comment
There was a problem hiding this comment.
Confirmed working great on Windows with only the MQ OTR
This was referenced Apr 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gSPSegmentwas modified to no longer replacenonmqwithmq. A new methodgSPSegmentLoadResreplicates the old behavior. I have swapped this function in place of textures that are loaded via code (the entrances white/black color when day/night, and KD lava tex). The crash was happening when only an MQ rom is loaded.Build Artifacts