Fix Randomizer_Item_Give corrupting inventory slots for MOD_RANDOMIZER items#2626
Merged
dcvz merged 3 commits intoHarbourMasters:developfrom Mar 14, 2023
Merged
Conversation
dcvz
approved these changes
Mar 14, 2023
Contributor
dcvz
left a comment
There was a problem hiding this comment.
LGTM! Welcome to the team! :D
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When adding
Randomizer_Item_GivetoOnItemReceive, I switched return statements toReturn_Item_Entrycalls, and thus even whenReturn_Item_Entrywas called, codeflow would still get to the end where it was trying to update inventory slots. This addsreturns back to those calls toReturn_Item_Entryto end item processing at those points.Build Artifacts