Fix: Clear Bongo-Bongo dead static effect on actor reset#2603
Merged
dcvz merged 1 commit intoHarbourMasters:develop-khanfrom Mar 12, 2023
Merged
Fix: Clear Bongo-Bongo dead static effect on actor reset#2603dcvz merged 1 commit intoHarbourMasters:develop-khanfrom
dcvz merged 1 commit intoHarbourMasters:develop-khanfrom
Conversation
briaguya0
approved these changes
Mar 9, 2023
aMannus
approved these changes
Mar 9, 2023
Contributor
aMannus
left a comment
There was a problem hiding this comment.
Must be nice being able to kill bongo bongo
dcvz
approved these changes
Mar 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Bongo-Bongo dies, his body color is darkened and then a static noise effect is applied. However, on subsequent re-fights in the same SoH instance, the darkened and static effects are still applied.
This is because these effects are stored as static variables and were not being reset properly.
This PR wires up the existing
Resetmethod to the bongo actor, and adds additional property resets to completely remove the darkened and static effects.Build Artifacts