Change autosave to use dropdown#2550
Merged
briaguya0 merged 1 commit intoHarbourMasters:developfrom Feb 28, 2023
Merged
Conversation
briaguya0
approved these changes
Feb 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dropdown now consolidates all hidden cvar usages into a single autosave cvar that uses an enum value instead of a boolean value. The old checkbox with no hidden cvars changed was set to "location + major items", so the value of 1 in the dropdown was set to the same usage so that all existing autosave users will be unchanged by this update.
This also adds a missing check to not autosave when changing areas if the shop rupee counter hasn't finished decrementing (a followup to #2079) and closes #2143.
Build Artifacts