Fix: MQ only cutscene crashes#2545
Merged
dcvz merged 1 commit intoHarbourMasters:developfrom Feb 27, 2023
Merged
Conversation
briaguya0
approved these changes
Feb 27, 2023
Contributor
briaguya0
left a comment
There was a problem hiding this comment.
Great fix! I got a little confused at first because we have LoadResource in resourcebridge as well as ResourceMgr_LoadResource in OTRGloabals
Glad this sorts it all out!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the resource refactor we were no longer accounting from swapping
/nonmq/to/mq/for cutscene resources, and fetching the cutscene with only a MQ rom loaded would lead to crashes.This updates the load CS resource function to use the method that handles converting nonmq -> mq paths.
Confirmed fixes #2452, fixes #2473
Build Artifacts