Rupee Dash Mode#2510
Rupee Dash Mode#2510Caladius wants to merge 20 commits intoHarbourMasters:developfrom Caladius:SuperSonic2
Conversation
garrettjoecox
left a comment
There was a problem hiding this comment.
I get the "sonic" thing is a bit of a meme, but are we sure that's what we want to name this? It's not super intuitive, to me at least
|
I know "Hole in Pocket" or "Burning Rupees"/"Burning Cash" were suggested as non-sonic names. We just need to make sure whatever name we settle on communicates rupees functioning as a timer/health. |
|
Naming of this is definitely not something I settled on, was just what I referred to it as when fleshing the idea out. It can be anything that makes sense for sure! |
|
A reference to the Magic Armor might keep it inside the Zelda universe but I'm not sure how to spin that into something that describes the mode very well. |
I have thought about making another mode where Nayrus Love consumes rupees on hit and the player is locked at a quarter heart. So maybe not directly tied to Magic Armor for this one but something akin to Doom Counter from final fantasy? |
|
@dcvz suggested "Rupee Dash" as the name and I dig it |
briaguya0
left a comment
There was a problem hiding this comment.
the suggested inlining
…per Sonic to Rupee Dash.
|
That should be everything pending, please let me know if there's anything additional or something new that needs adjusting. |
dcvz
left a comment
There was a problem hiding this comment.
Looks good overall! Just had a small doubt
| Rupees_ChangeBy(-1); | ||
| } else { | ||
| if (gSaveContext.health > 0) { | ||
| gSaveContext.health = gSaveContext.health - 16; |
There was a problem hiding this comment.
Is there a danger that health is 10 or something and you subtract 16 from it? Would the game handle it?
Do we need to do something like:
gSaveContext.health = std::min(gSaveContext.health - 16, 0);There was a problem hiding this comment.
@dcvz im not taking suggestions at this time... lmao jk.
Solid point, i can double check but im pretty sure i had a quarter heart less than full at i just died rather than crashing ot anything
…per Sonic to Rupee Dash.
This reverts commit d2848d0.
Adds a new Difficulty Option
Build Artifacts