CrowdControl V2: Effect overhaul#2433
Merged
dcvz merged 36 commits intoHarbourMasters:developfrom Mar 13, 2023
Merged
Conversation
14 tasks
Archez
reviewed
Feb 16, 2023
dcvz
reviewed
Mar 1, 2023
soh/soh/Enhancements/game-interactor/GameInteractor_RawAction.cpp
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whenever we release the SoH version that includes this, we have to communicate with the CC team to upload the .cs file on their end. They'll also have to add all the effect descriptions and prices which can be found in the .ccpak file, and update the images for the effects accordingly.
Thanks to Caladius for being a sparring partner & helping me with some tedious stuff.
Thanks to RR for lending me their Random Bonk While Rolling code.
Thanks to dcvz for helping me get GameInteractor out the door that made all of this much easier to implement.
To do:
New effects:
Removed Effects:
Other features:
Bugfixes:
Build Artifacts