Skip to content

Update BUILDING.md#2385

Merged
briaguya0 merged 2 commits intoHarbourMasters:developfrom
hannahbee91:patch-1
Mar 1, 2023
Merged

Update BUILDING.md#2385
briaguya0 merged 2 commits intoHarbourMasters:developfrom
hannahbee91:patch-1

Conversation

@hannahbee91
Copy link

@hannahbee91 hannahbee91 commented Jan 23, 2023

I use PyEnv and rebuilding after recent commits was giving me a cmake error about not being able to find the Python3 executable. Advising other users who might run into this problem on how to fix it.

Build Artifacts

I use PyEnv and rebuilding after recent commits was giving me a cmake error about not being able to find the Python3 executable. Advising other users who might run into this problem on how to fix it.
@briaguya0
Copy link
Contributor

I wonder if this can/should be addressed in the cmake files directly instead of the readme

@leggettc18
Copy link
Contributor

I disagree, I think this is the better solution. My research so far on getting CMake to find the PyEnv path involves changing things that would probably break FindPython for the normal path, so we'd still need to have some kind of property the user would need to provide to signal to cmake that it needs to override where FindPython looks. And even then it would only be for PyEnv, if there are any other nonstandard ways to install Python we would also need to add overrides for those as well. Compared to that, asking users of non-standard python installation to provide the path to their interpreter this way seems very reasonable to me.

@leggettc18
Copy link
Contributor

Well, as soon as I finished typing that I found this which might do what we need: pyenv/pyenv#310 (comment)

@briaguya0
Copy link
Contributor

i'm not opposed to just updating BUILDING.md, just wanted to make sure we weighed our options.

thanks for looking into this @leggettc18!

@briaguya0 briaguya0 merged commit 0daa91f into HarbourMasters:develop Mar 1, 2023
@hannahbee91 hannahbee91 deleted the patch-1 branch May 16, 2024 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants