workaround for vanilla save check tracker crash#2359
Merged
briaguya0 merged 1 commit intoHarbourMasters:develop-bradleyfrom Jan 18, 2023
Merged
workaround for vanilla save check tracker crash#2359briaguya0 merged 1 commit intoHarbourMasters:develop-bradleyfrom
briaguya0 merged 1 commit intoHarbourMasters:develop-bradleyfrom
Conversation
Archez
approved these changes
Jan 18, 2023
leggettc18
approved these changes
Jan 18, 2023
Contributor
leggettc18
left a comment
There was a problem hiding this comment.
Proper fix is that check tracker probably shouldn't use this or we need to add all the item entries but that's more of a feature than a fix, so this is fine as a band-aid fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #2336
the true solution would be updating the tracker to fully support tracking vanilla saves, but that's way out of scope for this fix. this fixes the crash, nothing less, nothing more.
Build Artifacts