Rando: Adjust locked door logic for temples and give starting keys for MQ Spirit#2343
Merged
dcvz merged 2 commits intoHarbourMasters:develop-bradleyfrom Jan 17, 2023
Merged
Conversation
briaguya0
approved these changes
Jan 17, 2023
dcvz
approved these changes
Jan 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In rando, we were unlocking the locked down that blocks the boss key chest in Fire temple, however this should only happen when keysanity is not active (vanilla placement/own dungeon). There was a todo to handle this.
I moved the handling of this into rando save init rather than being in the actor file. I also placed this and the water temple locked door change within a vanilla dungeon check as these are only needed for vanilla dungeons.
I also noticed we missed a logic edge case where MQ Spirit with vanilla small keys expects to start with 3 keys as logic can't handle the vanilla key layout.
Build Artifacts