Fix: Entrance Rando Castle courtyard exit#2316
Merged
briaguya0 merged 1 commit intoHarbourMasters:develop-bradleyfrom Jan 17, 2023
Merged
Fix: Entrance Rando Castle courtyard exit#2316briaguya0 merged 1 commit intoHarbourMasters:develop-bradleyfrom
briaguya0 merged 1 commit intoHarbourMasters:develop-bradleyfrom
Conversation
…ungeon entrance randomizer
briaguya0
approved these changes
Jan 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is an entrance edge case where exiting the castle courtyard crawlspace uses the same entrance index as exiting ganon's castle. This would allow child link to "spoil" where ganon's castle is shuffled too.
I had a check if you were in the courtyard scene to prevent overriding that entrance, but turns out being in the courtyard at night is considered a different scene and so this check was missing that.
PR adds the other scene to the check to fix this edge case.
Build Artifacts