Enemy rando - Fix silver rupee room in GtG#2252
Merged
briaguya0 merged 1 commit intoHarbourMasters:develop-bradleyfrom Dec 24, 2022
Merged
Enemy rando - Fix silver rupee room in GtG#2252briaguya0 merged 1 commit intoHarbourMasters:develop-bradleyfrom
briaguya0 merged 1 commit intoHarbourMasters:develop-bradleyfrom
Conversation
briaguya0
approved these changes
Dec 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Killing an enemy in the timed silver rupee room in GtG sometimes opened the door without collecting the rupees. Turns out there's an exception in the silver rupee tracker actor that for some reason uses the same flag as killing all enemies only in this room.
The authentic game has an out of bounds wallmaster in this room, which prevents the other wallmaster in this room ever triggering this flag. This PR stops the randomization of the OoB wallmaster, which kinda had to be done anyway because it falsely led to a second enemy in this room sometimes when the second enemy could make its way back in-bounds.
Build Artifacts