Rando - Fix particle regression#2228
Merged
briaguya0 merged 1 commit intoHarbourMasters:develop-bradleyfrom Dec 21, 2022
Merged
Rando - Fix particle regression#2228briaguya0 merged 1 commit intoHarbourMasters:develop-bradleyfrom
briaguya0 merged 1 commit intoHarbourMasters:develop-bradleyfrom
Conversation
briaguya0
approved these changes
Dec 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometime after Shopsanity was merged in, the particles for warp songs etc were changed to make them more compact in shops. But this change was applied to every item with particles, not just the shops.
This properly brings back the particles like they were before. One additional change to those particles was made where we shortened the lifespan from 50 to 30 to make them a little less visually agressive.
See this clip for the difference in lifespan: https://cdn.discordapp.com/attachments/982811550467387392/1054901377131876393/2022-12-21_00-20-28.mp4
Build Artifacts