Skip to content

changes to the asset extraction script #2068

Merged
briaguya0 merged 1 commit intoHarbourMasters:develop-bradleyfrom
Alto1772:extract-script
Jan 17, 2023
Merged

changes to the asset extraction script #2068
briaguya0 merged 1 commit intoHarbourMasters:develop-bradleyfrom
Alto1772:extract-script

Conversation

@Alto1772
Copy link
Contributor

@Alto1772 Alto1772 commented Dec 1, 2022 •
edited by github-actions bot
Loading

  • fixes exiting with Ctrl+C on linux. You can't quit this script with normal ^C in interactive. You'll have to kill its process!
  • chooseROM returns Z64Rom object in addition to speed, so we don't have to execute Z64Rom() or its static methods like isValidRom every time to read the rom file's headers, and that makes it a slight slow on some computers.
  • adds simple verbosity for inspecting roms, just to make sure if the version of your rom file you wanted to extract is correct

Any suggestions or issues are welcome...

Build Artifacts

@Alto1772
changes to the asset extraction script
229d76d 
- fixes exiting with Ctrl+C on linux
- chooseROM returns Z64Rom object in addition to speed
- adds simple verbosity for inspecting roms
@briaguya0 briaguya0 force-pushed the develop branch 2 times, most recently from 05bd4a3 to ba13e6b Compare January 17, 2023 05:34
@briaguya0 briaguya0 changed the base branch from develop to develop-bradley January 17, 2023 22:04
@briaguya0 briaguya0 merged commit ba5d5c2 into HarbourMasters:develop-bradley Jan 17, 2023
@Alto1772 Alto1772 deleted the extract-script branch February 7, 2023 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dcvz dcvz dcvz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

merge ready

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Alto1772 @dcvz @briaguya0