Skip to content

Fix Gerudo Warrior Clothing#1752

Merged
briaguya0 merged 2 commits intoHarbourMasters:develop-zhorafrom
xoascf:fix-gerudo-warrior-clothing
Oct 13, 2022
Merged

Fix Gerudo Warrior Clothing#1752
briaguya0 merged 2 commits intoHarbourMasters:develop-zhorafrom
xoascf:fix-gerudo-warrior-clothing

Conversation

@xoascf
Copy link
Member

@xoascf xoascf commented Oct 11, 2022

Closes #1240.

@aMannus
Copy link
Contributor

aMannus commented Oct 12, 2022

I'm confused, this just puts a CVar around existing code right? How does this fix the issue it's supposed to fix?

@briaguya0
Copy link
Contributor

I'm confused, this just puts a CVar around existing code right? How does this fix the issue it's supposed to fix?

if i'm understanding this correctly, we already have a fix implemented for an authentic bug, this makes it so that fix is wrapped in a cvar

@Rozelette
Copy link
Contributor

Actually I think this is a fix for the GC versions. See https://github.com/zeldaret/oot/blob/c3dc2994485277e3ff17f63f89335ab5c1cca7c6/src/overlays/actors/ovl_En_Ge3/z_en_ge3.c#L241 in the decomp. Regardless, we generally target the N64 version when it comes to what bugs to keep, so it makes sense to move this to a CVar.

@briaguya0
Copy link
Contributor

Actually I think this is a fix for the GC versions. See https://github.com/zeldaret/oot/blob/c3dc2994485277e3ff17f63f89335ab5c1cca7c6/src/overlays/actors/ovl_En_Ge3/z_en_ge3.c#L241 in the decomp. Regardless, we generally target the N64 version when it comes to what bugs to keep, so it makes sense to move this to a CVar.

iirc it was fixed in 1.1 (maybe only PAL 1.1)

@briaguya0
Copy link
Contributor

@xoascf could you point this at zhora?

@aMannus
Copy link
Contributor

aMannus commented Oct 12, 2022

Could you also add this to the default enhancement preset zeroing it out?

@xoascf xoascf force-pushed the fix-gerudo-warrior-clothing branch from 0cc053e to 8e97f5a Compare October 12, 2022 21:31
@xoascf xoascf changed the base branch from develop to develop-zhora October 12, 2022 21:31
Co-authored-by: briaguya <70942617+briaguya-ai@users.noreply.github.com>
@briaguya0 briaguya0 merged commit 42a5f46 into HarbourMasters:develop-zhora Oct 13, 2022
@xoascf xoascf deleted the fix-gerudo-warrior-clothing branch October 13, 2022 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

gerudo chief clothing doesn't update to match tunic

5 participants