The Setting Description for reference:

For those who want to play the game normally but with the improvements of the randomizer. All locations will contain their vanilla items. This supercedes all item shuffle, logic, hint, and item pool settings. You can still use non-vanilla world settings such as adult start or entrance shuffle, but the game may require glitches to complete if you do.

Both this and enabling cutscene skips and the other rando timesavers outside of rando should be done, as this option can be combined with certain world options, such as entrance rando, to make some interesting scenarios. That being said, some more work should be done before this can be merged to actually disable those superceded settings, as they can be disregarded by 3drando during seed generation but still be enabled in the save context and that might spell trouble in certain situations.

Also this is probably missing the bit that outputs this setting to the spoiler file and the bit that parses that setting from the spoiler file, so the setting wouldn't be set appropriately when sharing seeds which could cause issues elsewhere.

For reference, I have #849 tracking the work to add all the other rando timesavers to vanilla.

Sorry I've been out the last couple of days so haven't had a chance to review comments properly.

Also this is probably missing the bit that outputs this setting to the spoiler file and the bit that parses that setting from the spoiler file, so the setting wouldn't be set appropriately when sharing seeds which could cause issues elsewhere.

The spoiler log output by this change does have "Logic Options:Logic": "Vanilla", in it, I guess since this was already an option in the UI to choose between No Logic and Glitchless and this is just a 3rd option in the enum the work to add this to the log is covered.

Both this and enabling cutscene skips and the other rando timesavers outside of rando should be done, as this option can be combined with certain world options, such as entrance rando, to make some interesting scenarios. That being said, some more work should be done before this can be merged to actually disable those superceded settings, as they can be disregarded by 3drando during seed generation but still be enabled in the save context and that might spell trouble in certain situations.

I'm not 100% clear on what is being suggested here? Did you want me to add logic to ensure that when the logic is set to vanilla I should disable the other rando options such as entrance rando? Just trying to understand from the comment whether this is something you want to see as part of this PR or as part of a future PR as we bring more rando timesavers out of rando?

Also just updated the description to have a link to the spoiler log generated by these settings for reference:
https://pastebin.com/R25Prt1X

The spoiler log output by this change does have "Logic Options:Logic": "Vanilla", in it, I guess since this was already an option in the UI to choose between No Logic and Glitchless and this is just a 3rd option in the enum the work to add this to the log is covered.

It's added to the log but this also needs to be read from the spoilerfile and that code still needs to be added.

I'm not 100% clear on what is being suggested here? Did you want me to add logic to ensure that when the logic is set to vanilla I should disable the other rando options such as entrance rando? Just trying to understand from the comment whether this is something you want to see as part of this PR or as part of a future PR as we bring more rando timesavers out of rando?

Most of that was for other people that would probably be saying "why are we doing this when we could also add cutscene skips to vanilla SoH", and I was explaining that we can combine this setting with some of the other rando settings. There are certain settings that you'll want to make sure get toggled off on the SoH side while this is on, like the sanities. Some of this gets a bit more complicated so we might be contributing a bit towards your branch later on.

As a sidenote, when playing through on this branch with the vanilla settings enabled we noticed that the BGS quest is still modified to give you the claim check from Anju. I would guess that for the vanilla logic setting the BGS sword quest should be left unmodified? I will try to take a look at that when I can.

Rando-next is retired. Feel free to re-open after pointing this PR to the 'develop' branch.