Merged
Conversation
…_DIAGNOSTIC wait types, and WAITFOR wait types.
…to allow future configurability on the number of long-running queries returned. Added optional parameter to control display of WAITFOR types in future.
…n instead of janky string addition.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds exclusions to
GetLongRunningQueriesAsync()to excludesp_server_diagnosticsandWAITFORwait types. Adds parameters toGetLongRunningQueriesAsync()for future use to allow precise control over exclusion of those wait types, along with an optional parameter to control the maximum number of long running queries returned to the caller.Which component(s) does this affect?
How was this tested?
Tested against SQL Server 2022 with sp_server_diagnostics wait types caused by Windows Server Failover Cluster monitoring, and via a manual query with
WAITFOR DELAY '00:30:00';Checklist
dotnet build -c Debug)