qsv: fixing mfx compilation options for Linux support#648
qsv: fixing mfx compilation options for Linux support#648sr55 merged 3 commits intoHandBrake:masterfrom
Conversation
contrib/libmfx/module.defs
Outdated
|
|
||
| LIBMFX.CONFIGURE.bootstrap = rm -fr aclocal.m4 autom4te.cache; autoreconf -fiv; | ||
|
|
||
| ifneq (1,$(FEATURE.qsv)) |
There was a problem hiding this comment.
I'm confused about what this is supposed to do. The libmfx contrib is only built when FEATURE.qsv == 1. So it would appear this will never add --without-libva_* since you can only get here if FEATURE.qsv == 1. Maybe this conditional should be checking BUILD.system instead? E.g.
ifneq (,$(filter $(BUILD.system),linux))
There was a problem hiding this comment.
@bradleysepos can help as well due to 77bdefe
General rule:
- it should not matter for cross/Windows compilation
- for Linux we need to have it: meaning NO: --without-libva_*
Note these (libva_drm and libva_x11) should be from MSS and not other(s)/default ones.
|
thanks @jstebbins : now it should be better and properly handle build PC where non MSS's libva* are installed. |
|
Is this going to impact GPL compatibility as it isn't free? |
|
Intel® Media Server Studio – Community Edition |
|
Seems fine from a diff standpoint. |
|
f293068 needed only before next mfx_dispatch update. |
|
OK. No objections here |
|
If there are no objections I'll merge this in tomorrow. |
|
I forgot this was pending. It's fine with me. |
Adds preliminary support for QSV on Linux,
requires MSS to be installed for run.
To build on PC without MSS installed and without iGPU/QSV :
libdrm and libvadev. packages should be still taken from MSS, compiled and placed that pkg-config can find it.