Merged
Conversation
|
I can confirm this fixes #2690 for me. |
Contributor
|
LGTM |
Allows specifying custom locations for pkg-config files, and makes the build system generally compatible with packaging systems such as Nix.
The previous hardcoded path is now the fallback.
2bb4b5f to
ed8b3a3
Compare
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves library detection for system packages and allows custom pkg-config files paths. On Linux, uses pkg-config to locate libxml2 for libhb if possible, falling back to the previous hardcoded path. FFmpeg looks for libxml2 in the same manner.
While I initially worked on these improvements due to #2690 (and this PR does fix building on NixOS), the solutions are more generic in nature and should make the build system a bit more robust in these areas.
Test on: