Skip to content

Use unique separator character for each rigctld connection#1771

Merged
N0NB merged 3 commits into
Hamlib:masterfrom
GeoBaltz:issue_1748
Jun 21, 2025
Merged

Use unique separator character for each rigctld connection#1771
N0NB merged 3 commits into
Hamlib:masterfrom
GeoBaltz:issue_1748

Conversation

@GeoBaltz

Copy link
Copy Markdown
Contributor

Copy global default separator into thread-local storage

Fix memory leak, and small omission in man page.

All for master, rigctld.c for 4.6.x

Fixes #1748

GeoBaltz added 3 commits June 21, 2025 04:39
strip_quotes() orphaned 1 or 2 strings per call.
Response to rigctld command was being corrupted by other threads
Fixes issue Hamlib#1748
@N0NB

N0NB commented Jun 21, 2025

Copy link
Copy Markdown
Contributor

What am I missing, George? It seems all three commits could go into 4.6.4?

@GeoBaltz

Copy link
Copy Markdown
Contributor Author

Oops, I see I wasn't very clear. That was more of a priority comment than absolute. They can all go in 4.6.4.

@N0NB N0NB merged commit 8d0e67f into Hamlib:master Jun 21, 2025
5 checks passed
@N0NB

N0NB commented Jun 21, 2025

Copy link
Copy Markdown
Contributor

Thanks George.

Ill close #1748.

@GeoBaltz GeoBaltz deleted the issue_1748 branch June 21, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong separator when multiple TCP clients simultaneously access to rigctld

2 participants