Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: Hamlib/Hamlib
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 4.6.4
Choose a base ref
...
head repository: Hamlib/Hamlib
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 4.6.5
Choose a head ref
  • 11 commits
  • 9 files changed
  • 3 contributors

Commits on Aug 6, 2025

  1. Update Kenwood max CW message size.

    GeoBaltz authored and N0NB committed Aug 6, 2025
    Configuration menu
    Copy the full SHA
    566d56b View commit details
    Browse the repository at this point in the history
  2. Fix one byte buffer overrun

    All the pictures in manuals show message as 4 bytes, but they don't
    include the major command (0x26).
    
    Found by `gcc -fanalyzer`
    GeoBaltz authored and N0NB committed Aug 6, 2025
    Configuration menu
    Copy the full SHA
    201f69b View commit details
    Browse the repository at this point in the history
  3. Advance to 4.6.5

    No proposed release date as of yet.
    N0NB committed Aug 6, 2025
    Configuration menu
    Copy the full SHA
    2d63d05 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2025

  1. Fix segfault when executing the dump_caps command

    Need to convert the level number 0..63 to the level bit mask.
    Steps to reproduce
    tests/rigctld -m 1 &
    tests/rigctl -m 2 dump_caps
    
    Fixes:
     Thread 1 "rigctl" received signal SIGSEGV, Segmentation fault.
     [..]
     (gdb) bt
     #0  __strlen_sse2 () at ../sysdeps/x86_64/multiarch/strlen-sse2.S:174
     #1  0x00007f532c46e300 in __printf_buffer (buf=buf@entry=0x7ffc320ad970, format=0x7f532c8aba22 "%s(%s) ", ap=0x7ffc320ada30, mode_flags=0) at ./stdio-common/vfprintf-process-arg.c:435
     #2  0x00007f532c491daf in __vsnprintf_internal (string=<optimized out>, maxlen=<optimized out>, format=<optimized out>, args=args@entry=0x7ffc320ada30, mode_flags=mode_flags@entry=0) at ./libio/vsnprintf.c:96
     #3  0x00007f532c469642 in __GI___snprintf (
         s=s@entry=0x7ffc320aec94 "BANDSELECT(00000..0.000000/0.000000) NR(0.000000..0.000000/0.000000) PBT_IN(0.000000..0.000000/0.000000) PBT_OUT(0.000000..0.000000/0.000000) CWPITCH(0..0/10) RFPOWER(0.050000..1.000000/0.001957) MICG"...,
         maxlen=maxlen@entry=3948, format=format@entry=0x7f532c8aba22 "%s(%s) ") at ./stdio-common/snprintf.c:31
     #4  0x00007f532c6dc14a in rig_sprintf_parm_gran (
         str=str@entry=0x7ffc320aec00 "ANN(0..0/0) APO(0..0/0) BACKLIGHT(0..0/0) BEEP(0..1316880384/1315832322) TIME(0..0/0) BAT(0..0/0) KEYLIGHT(0..0/0) SCREENSAVER(0..4/0) AFIF(0..0/0) BANDSELECT(00000..0.000000/0.000000) NR(0.000000..0."...,
         nlen=nlen@entry=4096, parm=9223372036854775807, gran=gran@entry=0x55f1f3cac338) at sprintflst.c:646
     #5  0x000055f1eb6cd487 in dumpstate (rig=rig@entry=0x55f1f3ca5b20, fout=fout@entry=0x7f532c5f25c0 <_IO_2_1_stdout_>) at dumpstate.c:408
     #6  0x000055f1eb6b4b81 in rigctl_dump_caps (rig=0x55f1f3ca5b20, fout=0x7f532c5f25c0 <_IO_2_1_stdout_>, fin=<optimized out>, interactive=<optimized out>, prompt=<optimized out>, vfo_opt=<optimized out>, send_cmd_term=13 '\r', ext_resp=0,
         resp_sep=10 '\n', cmd=0x55f1eb6dc0e0 <test_list+5760>, vfo=536870912, arg1=0x0, arg2=0x55f1eb6d1ce8 "", arg3=0x55f1eb6d1ce8 "") at rigctl_parse.c:4622
     #7  0x000055f1eb6c65f6 in rigctl_parse (my_rig=<optimized out>, fin=<optimized out>, fout=<optimized out>, argv=argv@entry=0x7ffc320b2138, argc=argc@entry=3, sync_cb=sync_cb@entry=0x0, interactive=<optimized out>, prompt=<optimized out>,
         vfo_opt=<optimized out>, send_cmd_term=<optimized out>, ext_resp_ptr=<optimized out>, resp_sep_ptr=<optimized out>, use_password=<optimized out>) at rigctl_parse.c:1847
     #8  0x000055f1eb6b0adc in main (argc=<optimized out>, argv=0x7ffc320b2138) at rigctl.c:801
    dforsi authored and N0NB committed Aug 12, 2025
    Configuration menu
    Copy the full SHA
    f88beb1 View commit details
    Browse the repository at this point in the history
  2. Update NEWS with seg fault fix

    N0NB committed Aug 12, 2025
    Configuration menu
    Copy the full SHA
    9141b47 View commit details
    Browse the repository at this point in the history
  3. Update Segfault-award for netrigctl_open() fix

    Congrats, Daniele!
    N0NB committed Aug 12, 2025
    Configuration menu
    Copy the full SHA
    8aca743 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2025

  1. Fix segfault with set_parm KEYERTYPE

    Steps to reproduce:
    tests/rigctl -m 1 \
    set_parm KEYERTYPE BUG
    
    Fixes:
     Thread 1 "rigctl" received signal SIGSEGV, Segmentation fault.
     __strlen_sse2 () at ../sysdeps/x86_64/multiarch/strlen-sse2.S:142
     warning: 142    ../sysdeps/x86_64/multiarch/strlen-sse2.S: File o directory non esistente
     (gdb) bt
     #0  __strlen_sse2 () at ../sysdeps/x86_64/multiarch/strlen-sse2.S:142
     #1  0x00007ffac346e300 in __printf_buffer (buf=buf@entry=0x7ffc3bcf40d0, format=0x7ffac38aef17 "%s", ap=0x7ffc3bcf4190, mode_flags=0) at ./stdio-common/vfprintf-process-arg.c:435
     #2  0x00007ffac3491daf in __vsnprintf_internal (string=<optimized out>, maxlen=<optimized out>, format=<optimized out>, args=args@entry=0x7ffc3bcf4190, mode_flags=mode_flags@entry=0) at ./libio/vsnprintf.c:96
     #3  0x00007ffac3469642 in __GI___snprintf (s=s@entry=0x7ffc3bcf4290 "", maxlen=maxlen@entry=32, format=format@entry=0x7ffac38aef17 "%s") at ./stdio-common/snprintf.c:31
     #4  0x00007ffac370b7b9 in dummy_set_parm (rig=0x558fe1991b20, parm=2048, val=...) at dummy.c:1704
     #5  0x0000558fb536afbe in rigctl_set_parm (rig=0x558fe1991b20, fout=0x7ffac35f25c0 <_IO_2_1_stdout_>, fin=<optimized out>, interactive=<optimized out>, prompt=<optimized out>, vfo_opt=<optimized out>, send_cmd_term=13 '\r', ext_resp=0,
         resp_sep=10 '\n', cmd=0x558fb5388000 <test_list+1440>, vfo=536870912, arg1=0x7ffc3bcf4e10 "KEYERTYPE", arg2=0x558fb537fdb1 "1", arg3=0x558fb537ece8 "") at rigctl_parse.c:3829
     #6  0x0000558fb53727d6 in rigctl_parse (my_rig=<optimized out>, fin=<optimized out>, fout=<optimized out>, argv=argv@entry=0x7ffc3bcf6fd8, argc=argc@entry=3, sync_cb=sync_cb@entry=0x0, interactive=<optimized out>, prompt=<optimized out>,
         vfo_opt=<optimized out>, send_cmd_term=<optimized out>, ext_resp_ptr=<optimized out>, resp_sep_ptr=<optimized out>, use_password=<optimized out>) at rigctl_parse.c:1847
     #7  0x0000558fb535cadc in main (argc=<optimized out>, argv=0x7ffc3bcf6fd8) at rigctl.c:801
    (cherry picked from commit 12ba558)
    dforsi authored and N0NB committed Aug 14, 2025
    Configuration menu
    Copy the full SHA
    1b70351 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2de2962 View commit details
    Browse the repository at this point in the history
  3. Update Segfault-award for rigctl fix

    Thanks, Daniele.
    N0NB committed Aug 14, 2025
    Configuration menu
    Copy the full SHA
    0236307 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2025

  1. Advance to 4.6.5 release

    N0NB committed Sep 5, 2025
    Configuration menu
    Copy the full SHA
    1e02402 View commit details
    Browse the repository at this point in the history
  2. Update NEWS for 4.6.5 release

    N0NB committed Sep 5, 2025
    Configuration menu
    Copy the full SHA
    8a6bd56 View commit details
    Browse the repository at this point in the history
Loading