[4.0] [CMS PR 28350] Move update of utf8 conversion table back do database model#38
Merged
Hackwar merged 1 commit intoHackwar:j4installfrom Mar 29, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue joomla#28350 (comment).
Summary of Changes
Move the update of the
#__utf8_conversiontablesconvertedvalue from the confiruration model back to the database model.I have no idea why that fixes the issue. Maybe this fix just masks another more funcamental issue with order of processing stuff? If so, feel free to discard this PR and solve it in another way.
Testing Instructions
See joomla#28350 (comment).
Expected result
No error about missing utf8 conversion shown in database checker.
Actual result
False error about missing utf8 conversion shown in database checker.
Documentation Changes Required
None.