Skip to content

fix: default force_generation to true and fix schedule-run skip logic#879

Merged
pethers merged 3 commits intomainfrom
copilot/aw-no-op-runs-tracking
Mar 31, 2026
Merged

fix: default force_generation to true and fix schedule-run skip logic#879
pethers merged 3 commits intomainfrom
copilot/aw-no-op-runs-tracking

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 31, 2026

Agentic news workflows were no-op'ing on scheduled (cron) runs because force_generation defaulted to false and the bash skip logic treated unset env vars as "don't force."

Changes

  • Default force_generation/force_translation to true in all 10 workflow .md and .lock.yml files
  • Fix bash default for schedule runs${EP_FORCE_GENERATION:-}${EP_FORCE_GENERATION:-true} so cron-triggered runs (where github.event.inputs is empty) force generation instead of skipping
  • Fix breaking news conditional!= "true"= "false" to match the same semantics
  • Fix translate workflow — was unconditionally passing --skip-existing; now respects force_translation flag

The core issue: for workflow_dispatch, the default value populates the input. For schedule triggers, github.event.inputs.force_generation is empty, not the default. So this:

# Before: empty string != "true" → always skips on schedule runs
if [ "${EP_FORCE_GENERATION:-}" != "true" ]; then
  SKIP_FLAG="--skip-existing"
fi

# After: empty string defaults to "true" → only skips on explicit false
if [ "${EP_FORCE_GENERATION:-true}" != "true" ]; then
  SKIP_FLAG="--skip-existing"
fi

Investigation: no hardcoded dates found

All workflows use dynamic dates ($TODAY, timeframe: "today"/"one-week"). The DATE GUARD warnings and analysis-before-noop mandates are already in place.

Copilot AI linked an issue Mar 31, 2026 that may be closed by this pull request
…to prevent no-op runs

- Change force_generation/force_translation default from false to true in all 10 workflow .md files
- Update corresponding .lock.yml files to match
- Fix EP_FORCE_GENERATION bash default to 'true' when unset (schedule runs)
- Fix breaking news force check to only skip on explicit false
- Update translate workflow to respect force_translation flag

Agent-Logs-Url: https://github.com/Hack23/euparliamentmonitor/sessions/62132379-18e8-45f9-b58d-d274d93c01b7

Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>
@github-actions github-actions bot added documentation Documentation updates infrastructure CI/CD and build infrastructure github_actions GitHub Actions updates config Configuration changes workflows GitHub workflows labels Mar 31, 2026
…rn across all workflows

Agent-Logs-Url: https://github.com/Hack23/euparliamentmonitor/sessions/62132379-18e8-45f9-b58d-d274d93c01b7

Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>
Copilot AI changed the title [WIP] Track no-op runs from agentic workflows fix: default force_generation to true and fix schedule-run skip logic Mar 31, 2026
Copilot AI requested a review from pethers March 31, 2026 11:45
@pethers pethers marked this pull request as ready for review March 31, 2026 11:46
@pethers pethers merged commit 63d1c1d into main Mar 31, 2026
16 checks passed
@pethers pethers deleted the copilot/aw-no-op-runs-tracking branch March 31, 2026 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

config Configuration changes documentation Documentation updates github_actions GitHub Actions updates infrastructure CI/CD and build infrastructure workflows GitHub workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[aw] No-Op Runs

2 participants