Skip to content

fix: resolve TypeScript 6 build:lib failures in tsconfig.lib.json#1745

Merged
pethers merged 2 commits intomainfrom
copilot/fix-tsconfig-lib-issues
Mar 31, 2026
Merged

fix: resolve TypeScript 6 build:lib failures in tsconfig.lib.json#1745
pethers merged 2 commits intomainfrom
copilot/fix-tsconfig-lib-issues

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 31, 2026 •
edited
Loading

npm run build:lib was failing under TypeScript 6 due to three missing compiler options in tsconfig.lib.json.

Changes

  • "rootDir": "./src" β€” TS6 now requires rootDir to be explicit when outDir/declarationDir are set (TS5011, triggered twice)
  • "ignoreDeprecations": "6.0" β€” silences TS5101 for baseUrl, consistent with tsconfig.json and cypress/tsconfig.json
  • "types": ["node"] β€” without this, process is unresolved (TS2591) across 13 source files that use process.env.NODE_ENV
"rootDir": "./src",
"outDir": "./lib",
"declarationDir": "./lib",
"declarationMap": true,
"ignoreDeprecations": "6.0",
"types": ["node"],
"baseUrl": ".",

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 31, 2026 •
edited
Loading

Dependency Review

βœ… No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA fef0163.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

Scanned Files

None

@pethers
fix: add rootDir, ignoreDeprecations, and types to tsconfig.lib.json …
fef0163 
…for TypeScript 6

Agent-Logs-Url: https://github.com/Hack23/blacktrigram/sessions/092d39d5-c2b2-4292-a11f-6a5a0ff256ce

Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix issues in tsconfig.lib.json for build fix: resolve TypeScript 6 build:lib failures in tsconfig.lib.json Mar 31, 2026
@github-actions github-actions bot added infrastructure CI/CD and build infrastructure config Configuration changes labels Mar 31, 2026
Copilot AI requested a review from pethers March 31, 2026 14:13
@pethers pethers marked this pull request as ready for review March 31, 2026 14:14
@pethers pethers requested a review from Copilot March 31, 2026 14:14
Copilot AI reviewed Mar 31, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes npm run build:lib failures under TypeScript 6 by aligning tsconfig.lib.json with TS6 requirements and the repo’s existing TS6 configuration.

Changes:

  • Add explicit rootDir to satisfy TS6 when outDir/declarationDir are set.
  • Add ignoreDeprecations: "6.0" to silence TS6 deprecation warnings (consistent with other tsconfigs).
  • Add types: ["node"] so process.env.NODE_ENV references typecheck during the library build.

@pethers pethers merged commit 15c5f62 into main Mar 31, 2026
16 checks passed
@pethers pethers deleted the copilot/fix-tsconfig-lib-issues branch March 31, 2026 14:19
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 31, 2026

πŸ“Έ Automated UI Screenshots

πŸ“‹ Screenshots Captured (8)

# Screenshot
1 01-splash-screen.png - 01 splash screen.png
2 02-intro-screen-menu.png - 02 intro screen menu.png
3 03-intro-screen-archetype-selector.png - 03 intro screen archetype selector.png
4 04-controls-screen.png - 04 controls screen.png
5 05-philosophy-screen.png - 05 philosophy screen.png
6 06-training-screen.png - 06 training screen.png
7 07-combat-screen-practice.png - 07 combat screen practice.png
8 08-combat-screen-versus.png - 08 combat screen versus.png

πŸ“¦ Download Screenshots

πŸ“₯ Download all screenshots from workflow artifacts

Screenshots are preserved as workflow artifacts for 30 days.

πŸ€– Generated by Playwright automation

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 31, 2026

πŸ“Έ Automated UI Screenshots

πŸ“‹ Screenshots Captured (8)

# Screenshot
1 01-splash-screen.png - 01 splash screen.png
2 02-intro-screen-menu.png - 02 intro screen menu.png
3 03-intro-screen-archetype-selector.png - 03 intro screen archetype selector.png
4 04-controls-screen.png - 04 controls screen.png
5 05-philosophy-screen.png - 05 philosophy screen.png
6 06-training-screen.png - 06 training screen.png
7 07-combat-screen-practice.png - 07 combat screen practice.png
8 08-combat-screen-versus.png - 08 combat screen versus.png

πŸ“¦ Download Screenshots

πŸ“₯ Download all screenshots from workflow artifacts

Screenshots are preserved as workflow artifacts for 30 days.

πŸ€– Generated by Playwright automation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@pethers pethers Awaiting requested review from pethers pethers is a code owner

Assignees

@pethers pethers

Copilot code review Copilot

Labels

config Configuration changes infrastructure CI/CD and build infrastructure

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pethers