After chatting on Slack to David Fowler (genius) he explained that there is no sync context in ASP.NET Core so the call to ConfigureAwait(false) is redundant and does nothing.
Old ASP.NET has a sync context for legacy reasons.
I won't pretend to understand 100% how sync contexts work but having had it confirmed I would recommend we take this call off all Tasks we are awaiting. It will helpfully make the code less intimidating for newcomers. Not an urgent issue.
@MisterJames @dpaquette - Before we work on this I wanted to check others are happy with the reasoning and approach?
@tonysurma I'll let you decide which milestone this fits into. I'm happy to work on it and in reality it's mostly find/replace and then a big commit after it tests correctly.
After chatting on Slack to David Fowler (genius) he explained that there is no sync context in ASP.NET Core so the call to ConfigureAwait(false) is redundant and does nothing.
Old ASP.NET has a sync context for legacy reasons.
I won't pretend to understand 100% how sync contexts work but having had it confirmed I would recommend we take this call off all Tasks we are awaiting. It will helpfully make the code less intimidating for newcomers. Not an urgent issue.
@MisterJames @dpaquette - Before we work on this I wanted to check others are happy with the reasoning and approach?
@tonysurma I'll let you decide which milestone this fits into. I'm happy to work on it and in reality it's mostly find/replace and then a big commit after it tests correctly.