docs + optional public asset URLs (failure modes, #272)#275
Merged
Conversation
…HKUDS#272) - Add docs/multimodal_rag_failure_modes.md and link from README + env.example - Optional RAGANYTHING_PUBLIC_ASSET_* env vars add *_public_url fields - New raganything/asset_urls.py; parser attaches URLs after path resolve - Tests for asset URL helper (force-add; test_* is gitignored for new files) Co-authored-by: Cursor <cursoragent@cursor.com>
- attach_public_media_urls now logs a single warning when only one of RAGANYTHING_PUBLIC_ASSET_BASE_URL / RAGANYTHING_PUBLIC_ASSET_STRIP_PREFIX is set, instead of silently no-oping. State resets when the env returns to either fully unset or fully set, so legitimate transitions still work. - Strip prefix resolution is hoisted into _resolve_strip_prefix and skipped entirely when the path cannot be resolved. - README and the failure-modes doc now flag that *_public_url is produced only on the MinerU parser path today; other parsers are not yet covered. - tests: added warn-once cases for each misconfiguration shape and a silent case when both env vars are absent. Reformatted the file so pre-commit's ruff-format hook passes (this was the previously failing CI step on this PR).
932d0ef to
30da9b6
Compare
This was referenced May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Happy to rename fields or adjust the env contract if you prefer another pattern — just say the word.