fix: remove redundant file_path_placeholder lookup in _merge_edges_then_upsert#2877
Merged
danielaskdd merged 1 commit intoHKUDS:mainfrom Apr 3, 2026
Merged
Conversation
…en_upsert `file_path_placeholder` was fetched from `global_config` twice in the same function — once before building the file paths list (line ~2164) and again inside the `> max_file_paths` branch (line ~2191). The second lookup is dead code because the variable was already in scope. Fixes HKUDS#2635 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Collaborator
|
@codex review |
|
Codex Review: Didn't find any major issues. Chef's kiss. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2635
In
_merge_edges_then_upsert(lightrag/operate.py),file_path_placeholderwas retrieved fromglobal_configtwice:already_file_pathsif len(file_paths_list) > max_file_paths:branch (line ~2191), where the variable is already in scope from the first lookupThe second lookup is dead code — it shadows the already-defined variable with an identical value. This PR removes it.
Changes
lightrag/operate.py: Removed duplicateglobal_config.get("file_path_more_placeholder", ...)call inside_merge_edges_then_upsertTest plan
pytest tests/excluding infra-dependent tests): 217 passed, 0 failed🤖 Generated with Claude Code