Addressing TODOs in PhysLean/QuantumMechanics/OneDimension/HarmonicOs… #838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cillator/Basic.lean
jstoobysmith
approved these changes
Dec 20, 2025
Member
jstoobysmith
left a comment
There was a problem hiding this comment.
This looks good to me! Many thanks! I will merge shortly
Member
|
Merged - many thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Addressing TODOs in PhysLean/QuantumMechanics/OneDimension/HarmonicOscillator/Basic.lean
Details
Refactoring
New Features/Proofs
Implemented proofs for the linearity of the schrodingerOperator.
Added schrodingerOperator_add: Proves the operator preserves addition.
Added schrodingerOperator_smul: Proves the operator preserves scalar multiplication.
Addressed and removed the corresponding TODO items from the file.