Skip to content

Fix Sniffnet crates.io package for Windows#718

Merged
GyulyVGC merged 9 commits intomainfrom
cargo-windows
Feb 16, 2025
Merged

Fix Sniffnet crates.io package for Windows#718
GyulyVGC merged 9 commits intomainfrom
cargo-windows

Conversation

@GyulyVGC
Copy link
Owner

Fixes #681.

This PR also adds a CI/CD step to the package.yml workflow to check the correctness of the crate before publication.

@GyulyVGC GyulyVGC added bug Something isn't working enhancement New feature, request, or improvement labels Feb 16, 2025
@GyulyVGC GyulyVGC added this to the v1.4.0 milestone Feb 16, 2025
@GyulyVGC GyulyVGC self-assigned this Feb 16, 2025
@GyulyVGC GyulyVGC added the Windows Something related to Windows operating system label Feb 16, 2025
Copy link
Owner Author

@GyulyVGC GyulyVGC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@GyulyVGC GyulyVGC merged commit 4784978 into main Feb 16, 2025
6 checks passed
@GyulyVGC GyulyVGC deleted the cargo-windows branch February 16, 2025 10:49
@GyulyVGC
Copy link
Owner Author

It turns out that winres is actually necessary. Reintroduced it in 88da289

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature, request, or improvement Windows Something related to Windows operating system

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sniffnet fails to build using the cargo installation (error RC2135 : file not found: ./resources/packaging/windows/graphics/sniffnet.ico)

1 participant