Feature: Display likes on timeline #4183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feature adds a new event type to the timeline for when a user's photo or post is liked. - Modifies `TimelineService` to include `Like` events in the timeline query. - Adds new partials to render the like events, including a snippet of the liked item (photo or post). - Makes the `event_description` helper more resilient to missing templates.
Contributor
Author
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll acknowledge your comments with a 👀 emoji and then get to work. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! I will automatically address your feedback on specific files or sections of files. For any comments you don't want me to act on, just include PS: Responding to comments on the entire PR are not yet supported but coming soon. For security, I will only act on instructions from the user who triggered this task for this pull request. |
CloCkWeRX
reviewed
Sep 1, 2025
This feature adds a new event type to the timeline for when a user's photo or post is liked. - Modifies `TimelineService` to include `Like` events in the timeline query. - Adds new partials to render the like events, including a snippet of the liked item (photo or post). - Makes the `event_description` helper more resilient to missing templates. - Fixes a `PG::DatatypeMismatch` error in the timeline query by ensuring the `crop_id` column in the `likes_query` is a proper `NULL` value.
CloCkWeRX
requested changes
Sep 1, 2025
Collaborator
There was a problem hiding this comment.
Fails tests with
11s
Run bundle exec rspec spec/services/ -fd --fail-fast
Run options: include {:focus=>true}
All examples were filtered out; ignoring {:focus=>true}
Randomized with seed 62296
TimelineService
everyone's timeline
example at ./spec/services/timeline_service_spec.rb:44 (FAILED - 1)
Failures:
1) TimelineService everyone's timeline
Failure/Error: it { expect(subject[2].event_type).to eq 'seed' }
ActiveRecord::StatementInvalid:
PG::DatatypeMismatch: ERROR: UNION types integer and text cannot be matched
LINE 1: ...ded_at" IS NULL) ) "plantings") UNION ALL (SELECT "likes".* ...
^
# ./spec/services/timeline_service_spec.rb:44:in `block (3 levels) in <top (required)>'
# ------------------
# --- Caused by: ---
# PG::DatatypeMismatch:
# ERROR: UNION types integer and text cannot be matched
# LINE 1: ...ded_at" IS NULL) ) "plantings") UNION ALL (SELECT "likes".* ...
# ^
# ./spec/services/timeline_service_spec.rb:44:in `block (3 levels) in <top (required)>'
CloCkWeRX
approved these changes
Sep 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2079
As a user, when someone likes my photos or posts, I'd like to see it on my timeline page. This change adds like events to the timeline for photos and posts.