Fix: Only show 'add a bio' link on own profile #4180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'add a bio' link on the member profile page was previously shown based on the `can? :edit, @member` ability check. This caused an issue for admins, who could see the link on other users' profiles, but the link would incorrectly lead to their own settings page. This change modifies the condition to be `member_signed_in? && current_member == @member`. This ensures the link is only displayed when a logged-in user is viewing their own profile, which is the correct and intended behavior.
Contributor
Author
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll acknowledge your comments with a 👀 emoji and then get to work. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! I will automatically address your feedback. For any comments you don't want me to act on, just include (aside). For security, I will only act on instructions from the user who triggered this task for this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3668
The 'add a bio' link on the member profile page was previously shown based on the
can? :edit, @memberability check. This caused an issue for admins, who could see the link on other users' profiles, but the link would incorrectly lead to their own settings page.This change modifies the condition to be
member_signed_in? && current_member == @member. This ensures the link is only displayed when a logged-in user is viewing their own profile, which is the correct and intended behavior.