Do not switch into context with unavailable edges#224
Merged
KristianKarl merged 1 commit intoGraphWalker:masterfrom Feb 20, 2020
Merged
Conversation
Fixed data logging Added debug loging
Codecov Report
@@ Coverage Diff @@
## master #224 +/- ##
============================================
+ Coverage 76.01% 76.07% +0.06%
- Complexity 1196 1205 +9
============================================
Files 129 129
Lines 4402 4418 +16
Branches 661 667 +6
============================================
+ Hits 3346 3361 +15
Misses 821 821
- Partials 235 236 +1 |
nilols
approved these changes
Feb 19, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR resolves the issue raised in GraphWalker fails to generate a path for models with shared state error and guards
The problem occurred when trying to switch into another model by a shared state, and that shared state had only out edges that were not accessible because of guards evaluating to false.
The solution is to not try to switch into such model, until an edge is accessible.
Also:
Fixed data logging
Added debug logging