Scan and use plugin generators#216
Merged
KristianKarl merged 2 commits intoGraphWalker:masterfrom Nov 28, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #216 +/- ##
===========================================
- Coverage 76.07% 75.97% -0.1%
- Complexity 1187 1195 +8
===========================================
Files 127 129 +2
Lines 4368 4400 +32
Branches 656 660 +4
===========================================
+ Hits 3323 3343 +20
- Misses 814 822 +8
- Partials 231 235 +4 |
Contributor
Author
|
@nilols Good to go? |
nilols
approved these changes
Nov 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a proposal to fix the issue discussed in New path generator to be recognized when defining the generator
I am implementing two new graph traversal algorithm so new path generators. I am wondering where can I set these new path generators to be recognized in the GraphWalker.
For example in the model.json file when I change the generator name to the new path generator I am implementing. -> "generator":"mynewgenerator(edge_coverage(100))"
Or
In the studio when we set the Generator field under execution tab like mynewgenerator(edge_coverage(100)) where in both cases "mynewgenerator" is my new path generator I want to be applied.
This PR would be able to scan for generators in the classpath and use them. Studio or CLI would the be run like:
Where myLib.jar contains a new [class] generator
PluginGenerator, and the model SimpleModel.json has the generator defined as: