Merged
Conversation
mohamedsalem401
commented
Jun 27, 2025
Comment on lines
-282
to
-292
| /** | ||
| * Checks if the target node has changed and returns the last one if they are identical. | ||
| * | ||
| * @param targetNode - The newly calculated target node. | ||
| * @returns The new or reused target node. | ||
| */ | ||
| private getOrReuseTargetNode(targetNode?: NodeType): NodeType | undefined { | ||
| const lastTargetNode = this.lastMoveData.targetNode; | ||
| return targetNode?.equals(lastTargetNode) ? lastTargetNode : targetNode; | ||
| } | ||
|
|
Contributor
Author
There was a problem hiding this comment.
This has nothing to do with the PR, just cleanup
mohamedsalem401
commented
Jun 27, 2025
| const sameHoverPosition = | ||
| sameHoveredNode && | ||
| sameHoveredIndex && | ||
| isWithinDropArea === targetNode.isWithinDropBounds(lastMouseEvent?.clientX ?? 0, lastMouseEvent?.clientY ?? 0); |
Contributor
Author
There was a problem hiding this comment.
Here, if last movement was over an undraggable area but now it's on draggable area, don't use the cached values
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where components dragged from an undroppable region into a droppable one were not being recognized. The fix implements a check that detects the transition based on the last mouse event, allowing the sorter to correctly handle these movements.