Merged
Conversation
Contributor
Author
|
With this change it is now possible to do the following: <script type="importmap">
{
"imports": {
"grapesjs": "https://unpkg.com/grapesjs/dist/grapes.mjs",
"grapesjs/locale/en": "https://unpkg.com/grapesjs/locale/en.mjs",
"grapesjs/locale/pt": "https://unpkg.com/grapesjs/locale/pt.mjs",
}
}
</script>Make sure you also load the styles correctly: <link rel="stylesheet" href="https://unpkg.com/grapesjs/dist/css/grapes.min.css"> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements a possible workaround for #2721
What's happening during the build is that first the source locale files are copied over from
packages/core/src/localetopackages/core/localeand then pushed through webpack for transpilation and the original files are overridden.For use cases where an ECMAScript module is required (e.g. when importing files using the
<script type="importmap">) it is imperative that the files are not transpiled. For that reason, before the transpilation, the original content is copied over to<filename>.mjsthus making a copy of the file in ECMAScript module format, which those files are originally in.