fix: Highlighted text selection cleared on shift-click#6412
Merged
artf merged 2 commits intoGrapesJS:devfrom Feb 21, 2025
Merged
fix: Highlighted text selection cleared on shift-click#6412artf merged 2 commits intoGrapesJS:devfrom
artf merged 2 commits intoGrapesJS:devfrom
Conversation
artf
approved these changes
Feb 21, 2025
Member
artf
left a comment
There was a problem hiding this comment.
Nice catch 👏
Thanks also for the tests. About the text selection itself no worries, I'm not against skipping tests close to the web API.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix is for #6345.
One concern here - I'm not sure how to test the actual text selection in the last unit test (it is disabled in this PR). If you have an idea I can try implementing it, otherwise I can just clear out that test if necessary.